Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update container-log-max-files-max-size #3774

Merged
merged 2 commits into from
Nov 5, 2024
Merged

update container-log-max-files-max-size #3774

merged 2 commits into from
Nov 5, 2024
+3 −1

Conversation

elieser1101
Copy link
Contributor

As requested in #3772

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @elieser1101!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2024
@dims
Copy link
Member

dims commented Nov 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 2, 2024
aojea
aojea reviewed Nov 3, 2024
View reviewed changes
hack/ci/e2e-k8s.sh Outdated Show resolved Hide resolved
@elieser1101 @aojea
update container-log-max-size
c613603 
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2024
@elieser1101
Copy link
Contributor Author

/test pull-kind-verify

@aojea
Copy link
Contributor

aojea commented Nov 4, 2024

@BenTheElder now it keeps the whole run in two files

https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kind/3774/pull-kind-e2e-kubernetes/1853039395674787840/artifacts/kind-control-plane/pods/kube-system_kube-apiserver-kind-control-plane_f15c9aff8d8905a46ac69983e98c39c7/kube-apiserver/

This is important to be able to debug problems on CI runs, specially rare flakes that does not happen frequently, is the second time this week it happens to me I can not debug because there are no logs when the problem happened

/lgtm
/approve

/hold

Wait for Ben

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, elieser1101

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
BenTheElder
BenTheElder reviewed Nov 4, 2024
View reviewed changes
hack/ci/e2e-k8s.sh
kubelet_extra_args=" \"v\": \"${KIND_CLUSTER_LOG_LEVEL}\""
kubelet_extra_args=" \"v\": \"${KIND_CLUSTER_LOG_LEVEL}\"
\"container-log-max-files\": \"10\"
\"container-log-max-size\": \"100Mi\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned whenever we have to do CI-only configuration @aojea, because it means we're no longer actually testing the defaults, do we think this is because of the verbosity on the components?

Copy link
Contributor

@aojea aojea Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compared with an e2e gce log the sizes are similar https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/128474/pull-kubernetes-e2e-gce/1852746024750157824/artifacts/e2e-44626956c7-674b9-master/

the difference is that those components logs to the filesystem, with the gorunner thingy, in kind everything logs to the pods and is rotated by the kubelet IIRC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the difference is that those components logs to the filesystem, with the gorunner thingy, in kind everything logs to the pods and is rotated by the kubelet IIRC

This seems like a gap to revisit later, ideally we want to make sure component logs have robust retention, but maybe not random pods.

@BenTheElder
Copy link
Member

Also, we could just change the defaults in kind, kubeadm, or kubelet. Again, I think we should avoid tuning the cluster "for CI", but in the fullness of capturing logs for debugging now

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit ce26184 into kubernetes-sigs:main Nov 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@BenTheElder BenTheElder

@stmcginnis stmcginnis

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elieser1101 @k8s-ci-robot @dims @stmcginnis @aojea @BenTheElder